libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unused variable in chase_symlinks


From: Ralf Wildenhues
Subject: Re: unused variable in chase_symlinks
Date: Tue, 24 Jul 2007 00:18:01 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

Hello Eric,

* Eric Blake wrote on Mon, Jul 23, 2007 at 09:02:44PM CEST:
> According to Ralf Wildenhues on 7/23/2007 11:44 AM:
> > * Eric Blake wrote on Mon, Jul 23, 2007 at 12:44:29AM CEST:
> >>    * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:
> >>    chase_symlinks): Avoid compiler warning.
> > 
> > If the list of (parenthesized) functions spans more than a line, please
> > close and reopen them.  I corrected it like this:
> > 
> >     * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
> >     (chase_symlinks): Avoid compiler warning.
> 
> But here, it is the chase_symlinks subsection of the
> func_emit_cwrapperexe_src function, which is so huge that it provides a
> bit a clarification where to look for the change.

Ouch.  So I completely messed that up.  Sorry about that.

> Maybe a better rendition would be:
> 
>       * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
>       <chase_symlinks>: Avoid compiler warning.

Yes.  Either that, or:

        * libltdl/config/ltmain.m4sh
        (func_emit_cwrapperexe_src:chase_symlinks): Avoid compiler
        warning.

but that would look a bit ugly, too.  Any way you prefer would be fine.
(If you just want to correct it, please go ahead, otherwise I'll choose
your rendition.)

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]