Re: [patch #6448] [MSVC 7/7] Add MSVC Support

[Ralf Wildenhues]

* Peter Rosin wrote on Sat, Aug 09, 2008 at 11:03:50AM CEST:
> Ralf Wildenhues skrev:
>> Does this BTW mean that the manifest file ends up being part of the .exe
>> and thus needs not be explicitly installed and uninstalled?  That would
>> be nice.
>
> Yes, the mt command embeds the manifest as a resource, so nothing extra to
> install.

Cool.

>>> 2008-08-07  Peter Rosin  <address@hidden>
>>>
>>>     * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) <postlink_cmds>:
>>>     New tag variable.
>>>     [ cygwin, mingw, cegcc ] <cl*>: Embed the manifest file as a
>>>     resource.
>>>     (_LT_LANG_CXX_CONFIG): Likewise.
>>>     * libltdl/config/ltmain.m4sh (func_mode_link): After linking
>>>     a program, replace @OUTPUT@ in $postlink_cmds and then execute
>>>     the commands.
>>
>> Not so bad; can we rely on 'mt' being present on all systems that have
>> cl?  Have you tried this patch on a setup where the program is relinked
>> at install time (does this ever happen with cl)?

> No, the manifest was introduced in MSVC 7 or 8 or something. MSVC 6 doesn't
> generate any manifests. That's one reason for the postlink_cmds to have
> if test -f @address@hidden;

Alright.

> That way, mt is only tried if there is a manifest file to embed, which also
> covers the case when the manifest file isn't needed (and thus not
> generated). If MSVC has generated a manifest, it better also have mt.

OK.

> It might be a problem if you build inside the src tree and a
> foo.exe.manifest is part of the source tree, and the .exe isn't generated
> in the .libs subdir. I guess you just shouldn't do that. Doctor, it hurts
> when I etc...

Good enough for me ATM.  Please go ahead and apply this on the branch,
thanks.

Cheers,
Ralf