libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #6448] [MSVC 7/7] Add MSVC Support


From: Peter Rosin
Subject: Re: [patch #6448] [MSVC 7/7] Add MSVC Support
Date: Tue, 12 Aug 2008 10:38:45 +0200
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)

Peter Rosin skrev:
Peter Rosin skrev:
Ralf Wildenhues skrev:

*snip*

Please try the patch below for simplistic at-file support with $NM.
While testing, I set nm_file_list_spec to '@' and always_export_symbols
to yes on GNU/Linux, and saw no test failure, probably because my nm
also understands '@'.  :-)
(IOW, we could enable that for when 'nm --help' lists @FILE.)

Probably the setting of nm_file_list_spec should be moved to where $NM
is set; not sure, as this is actually a Windows feature, not a $NM one.

I tried the patch and it fixes the old testsuite pdemo test, excellent!
But pdemo still fails due to an exported variable. Sigh. Why does each and every damn test (well, almost) have to export a variable when that's listed
as not portable in the docs? Seems masochistic to me...

From my point of view, you may push the ltmain part of the patch. I'll test
any improved m4 code when you have settled on how to enable it. However,
your idea to check the help output will not work, dumpbin -? doesn't
indicate any support whatsoever for @.

Maybe hook into the existing
AC_CACHE_CHECK([the name lister ($NM) interface], [lt_cv_...
and add
  if test "$lt_cv_nm_interface" = "MS dumpbin"; then
    _LT_TAGVAR(nm_file_list_spec, $1)='@'
  fi
to the end of LT_PATH_NM?

But I don't know it's too early to use _LT_DECL/_LT_TAGVAR?

It works to have it in LT_PATH_NM, so that's where I'd put it. Like
the attached patch...

Also, I tested the patch on the new testsuite and with this patch
I get the desired behaviour in the cmdline_wrap.at test (73).

I pushed the other patches[1][2], but this one is also on the list of
things I like. Ok to push to the msvc branch?

Cheers,
Peter

[1] http://lists.gnu.org/archive/html/libtool-patches/2008-08/msg00018.html
[2] http://lists.gnu.org/archive/html/libtool-patches/2008-08/msg00019.html




reply via email to

[Prev in Thread] Current Thread [Next in Thread]