Re: [patch] allow --with-pic to accept package names

[Ollie Wild]

On Thu, Oct 21, 2010 at 5:29 PM, Ollie Wild <address@hidden> wrote:
>
> This is motivated by GCC.  We compile Fortran shared libraries which
> must execute on systems with no libgfortrans.so.  The usual approach,
> passing --with-pic to configure is undesirable because it reduces the
> performance of other static libraries.  Instead, I have modified
> --with-pic to accept a list of packages (as --enable-shared does).
>
> This allows us to configure GCC with --with-pic=libgfortran to compile
> only libgfortran.a with position-independent code.
>
> All tests pass with and without this change.  I have not added a new
> test.  AFAICT, the demo-[no]pic-* tests don't actually check that
> -fPIC is used during compilation, and there doesn't appear to be a
> comparable test for --enable-shared.  If you would prefer a test for
> this feature, please provide suggestions for how to approach this (I
> am not familiar with the libtool testing framework).
>
> Thanks,
> Ollie
>
>
> 2010-10-21  Ollie Wild  <address@hidden>
>
>        Modify --with-pic to support per-package configurations.
>        * libltdl/m4/libtool.m4:  Modify --with-pic to accept a list of
>        package names.  Modelled off --enable-shared.

Peter, thanks for noticing the quoting bug.  Updated patch attached.

I've removed quoting of $withval, but left $lt_save_ifs quoting in
place.  That's consistent with --enable-shared, and even though the
new value of IFS may make that unnecessary, I'd prefer to be
conservative.

(BTW, please cc me directly on responses.  I am not on the
libtool-patches mailing list.)

Ollie

2010-10-21  Ollie Wild  <address@hidden>

        Modify --with-pic to support per-package configurations.
        * libltdl/m4/libtool.m4:  Modify --with-pic to accept a list of
        package names.  Modelled off --enable-shared.

with-pic.txt
Description: Text document