[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] allow --with-pic to accept package names
From: |
Peter Rosin |
Subject: |
Re: [patch] allow --with-pic to accept package names |
Date: |
Fri, 22 Oct 2010 23:02:16 +0200 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.11) Gecko/20101013 Thunderbird/3.1.5 |
Hi Ollie,
Den 2010-10-22 18:32 skrev Ollie Wild:
> On Thu, Oct 21, 2010 at 5:29 PM, Ollie Wild <address@hidden> wrote:
>> 2010-10-21 Ollie Wild <address@hidden>
>>
>> Modify --with-pic to support per-package configurations.
>> * libltdl/m4/libtool.m4: Modify --with-pic to accept a list of
>> package names. Modelled off --enable-shared.
>
> Peter, thanks for noticing the quoting bug. Updated patch attached.
>
> I've removed quoting of $withval, but left $lt_save_ifs quoting in
> place. That's consistent with --enable-shared, and even though the
> new value of IFS may make that unnecessary, I'd prefer to be
> conservative.
There is never any need to quote the right-hand side of assignments,
unless you have literal whitespace in them. If you do
a=foo; b=" bar"; c=$a$b; d=$c
both $c and $d will be "foo bar".
See 'Shell Substitutions' in the 'Portable Shell' chapter in the
autoconf manual.
But, there are so many examples of spurious quotes that a few more
will not make much difference. I'm sure I'm not innocent either
for that matter. I just stated tangential info since the problematic
quoting needed fixing, and since that is fixed I don't see any need
to do a re-spin just because of this.
> (BTW, please cc me directly on responses. I am not on the
> libtool-patches mailing list.)
Oops, sorry about that...
Cheers,
Peter