[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Description has changed:

Diff:

• Needs: -->
• Patch: new --> review
• Comment:

Passes make, make check and a full make doc.

---

[issues:#5340] Simplify Spacing_spanner::get_columns

Status: Started
Created: Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
Last Updated: Mon Jun 11, 2018 11:02 AM UTC
Owner: Dan Eble

Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column). There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.

http://codereview.appspot.com/348940044

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto