|
| From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
| Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns |
| Date: | Sat, 16 Jun 2018 18:27:54 -0000 |
commit bb34e5bbfdcf8d10877b5b85a339416f0a03c39b (HEAD -> pushed/issue-5340-used-columns-in-range, origin/staging)
Author: Dan Eble address@hidden
Date: Mon Jun 11 06:47:48 2018 -0400
Issue 5340: Simplify Spacing_spanner::get_columns The old algorithm filtered the system's list of columns into a list of used columns, then searched the filtered list for the endpoints of the range to return. The search key was the "rank" of a column, which is its index in the unfiltered list of columns (see System::add_column). There is therefore no need to search. The new algorithm selects the desired range in the unfiltered list and then filters that. This commit also removes the unused function Paper_column::compare.
[issues:#5340] Simplify Spacing_spanner::get_columns
Status: Fixed
Labels: Fixed_2_21_0
Created: Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
Last Updated: Sat Jun 16, 2018 08:48 AM UTC
Owner: Dan Eble
Simplify Spacing_spanner::get_columns
The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.
The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column). There is
therefore no need to search.
The new algorithm selects the desired range in the unfiltered list and
then filters that.
This commit also removes the unused function Paper_column::compare.
http://codereview.appspot.com/348940044
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
| [Prev in Thread] | Current Thread | [Next in Thread] |