Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120)

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Mittwoch, 11. Juni 2008 schrieben Sie:
> 2008/6/6 Reinhold Kainhofer <address@hidden>:
> > Attached is a patch (for current master), which is my first attempt to
> > implent this. The patch is not perfect yet, but works really well. What
> > it does: - Extend the parser to allow the above forms for \tempo
> >  - Add a tempoText property, similar to tempoUnitCount
> >  - Metronome_mark_engraver uses this property and checks whether it has
> >     changed
> >  - Extend the metronomeMarkFormatter to take four arguments (text,
> > duration, count, context) and print either the text, the note=count or
> > text (note=count), depending on whether the properties are set to
> > sensible values.
>
> That's really good.
>
> If I might make a suggestion, it would be nice to have an additional
> feature whereby the tempo can be set silently (perhaps controlled by a
> boolean context property), which would allow the text to be displayed
> while preserving the default behaviour of \tempo.

How about \tempo "new text"? This does not change the tempoUnitDuration and 
tempoUnitCount 

> > So, what shall I change in the patch?
>
> Do you need to have two extra functions in ly-syntax-constructors.scm?
> They seem a bit out of place there, since they're too specific (being
> a subset of tempo).
>
> Could the tempo function be rewritten to incorporate the other
> options, with default values being passed by the parser for the
> properties not set?

Probably, yes. I just took the easy way and added two new specialized  
functions...
Actually, thinking a bit more: The tempo and tempoWithText should probably be 
merged (\tempo 4=120 should set an empty text, shouldn't it?). But I'm not so 
sure about tempoText, since that changes only the text, but not unit and 
duration... Or should \tempo "Textual representation" set the count to 0? 


Cheers,
Reinhold
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFITx4BTqjEwhXvPN0RAh9IAJ9NasH0SDdDbs0ugK9UN748gEOcBwCgpCwX
iATeys9O6DCENQ8VfFYYu2Y=
=zM9k
-----END PGP SIGNATURE-----