Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120)

[Reinhold Kainhofer]

Am Freitag, 13. Juni 2008 schrieb Reinhold Kainhofer:
> Am Freitag, 13. Juni 2008 schrieb Neil Puttock:
> > 2008/6/12 Reinhold Kainhofer <address@hidden>:
> > > Am Mittwoch, 11. Juni 2008 schrieb Neil Puttock:
> > >
> > > Here is an updated patch with all the issues resolved. I've also added
> > > a regression test, the corresponding PDF file is uploaded at:
> > > http://www.fam.tuwien.ac.at/~reinhold/temp/metronome-text.pdf
>
> -...]
>
> > - since format-metronome-markup determines whether to create the text
> > markup by checking for an empty list, you probably want the parser to
> > send SCM_EOL for \tempo dur = count; otherwise you'll get the
> > unfortunate result shown below. :)
>
> Oops, you really got me there. If there is a text, I set the tempoText
> property, but I forgot that if that property is already set, I need to
> unset it there... Fixed with the attached patch.

Since that last mail didn't get any responses, I'll ask again: Is the patch 
now okay to be pushed to master?

One thing that I don't like about it is that in the parser I haven't found a 
way to match a string or markup, so I had to duplicate the cases:

+       | TEMPO string steno_duration '=' bare_unsigned {
+               $$ = MAKE_SYNTAX ("tempo", @$, make_simple_markup($2), $3, 
scm_int2num ($5));
+       }
+       | TEMPO full_markup steno_duration '=' bare_unsigned    {
+               $$ = MAKE_SYNTAX ("tempo", @$, $2, $3, scm_int2num ($5));
+       }


Did I miss some pattern that matches a string and a full markup (and can be 
used equivalently in the tempo and tempoText calls)?

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/