[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixing bugs #379 and #427
From: |
Neil Puttock |
Subject: |
Re: Fixing bugs #379 and #427 |
Date: |
Fri, 14 Aug 2009 01:25:49 +0100 |
2009/8/14 Neil Puttock <address@hidden>:
> Will report back once I've given the patch a whirl.
This is already very impressive, as far as I can tell.
I've just run `make check' and there are no important changes visible,
but I imagine that's due to the fact we haven't got any tests which
really exercise this issue properly (as I noted in the original bug
report, it's a bit silly declaring that slurs behave well at line
breaks if there are no prefatory items in the way to test this
assertion properly).
Two issues have caught my eye (one minor, the other more serious):
1. After a break, I think there's too little space between key
signature alterations and a continuation (though this also applies to
ties, so it's probably a more general issue): at low resolutions, they
often appear to be touching.
\paper { ragged-right = ##t }
\relative c'' {
\key a \major
fis1( \break
gis2 b)
}
2. Breakable items in another stave cause a slur to end prematurely
before a break.
\paper { ragged-right = ##t }
\relative c' {
<<
\new Staff {
c4( d e f \break
g1)
}
\new Staff {
c,4 d e f
\clef alto
g1
}
>>
}
Regards,
Neil