[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixing bugs #379 and #427
From: |
Patrick McCarty |
Subject: |
Re: Fixing bugs #379 and #427 |
Date: |
Thu, 13 Aug 2009 23:34:42 -0700 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On 2009-08-14, Neil Puttock wrote:
>
> Two issues have caught my eye (one minor, the other more serious):
>
> 1. After a break, I think there's too little space between key
> signature alterations and a continuation (though this also applies to
> ties, so it's probably a more general issue): at low resolutions, they
> often appear to be touching.
>
> \paper { ragged-right = ##t }
> \relative c'' {
> \key a \major
> fis1( \break
> gis2 b)
> }
Okay, noted. This should be easy to fix, since the interval would
just need to be expanded slightly, maybe depending on slur thickness.
> 2. Breakable items in another stave cause a slur to end prematurely
> before a break.
>
> \paper { ragged-right = ##t }
> \relative c' {
> <<
> \new Staff {
> c4( d e f \break
> g1)
> }
> \new Staff {
> c,4 d e f
> \clef alto
> g1
> }
> >>
> }
Yeah, that's a big problem. I need to do a more thorough
investigation of the slur code to figure out why that's happening.
Also, looking through git history, the function I removed in my patch
(Slur_score_state::breakable_bound_item) was added in 2006 by Han-Wen
to fix #120. With my patch, #120 reappears.
Back to the drawing board for me. :-)
Thanks for your feedback,
-Patrick