[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
* Fix quoting overrides, set etc.
From: |
n . puttock |
Subject: |
* Fix quoting overrides, set etc. |
Date: |
Tue, 29 Sep 2009 16:10:15 +0000 |
LGTM.
There are a few trailing spaces in the regtest though.
Some of the lines in recording-group-emulate are far too long
(particularly where you've added the comment).
http://codereview.appspot.com/124064/diff/1/2
File input/regression/quote-overrides.ly (right):
http://codereview.appspot.com/124064/diff/1/2#newcode5
Line 5: @code{\\override}, @code{\\once\\override}, @code{\\revert},
@code{\\set},
space after \\once
http://codereview.appspot.com/124064/diff/1/2#newcode23
Line 23: % Checking \once\override
\once \override
http://codereview.appspot.com/124064/diff/1/3
File scm/part-combiner.scm (right):
http://codereview.appspot.com/124064/diff/1/3#newcode213
Line 213: ; The accumulate-event-listener above creates the list of
events in reverse order,
;;
http://codereview.appspot.com/124064/diff/1/3#newcode214
Line 214: ; so we have to revert it to be in the original order again
;;
http://codereview.appspot.com/124064
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- * Fix quoting overrides, set etc.,
n . puttock <=