[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by
|
From: |
lemzwerg |
|
Subject: |
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by address@hidden) |
|
Date: |
Thu, 06 Jun 2019 23:47:17 -0700 |
Indentation problems...
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode77
aclocal.m4:77: STEPMAKE_ADD_ENTRY($3, $2)
This looks strange, at least here in appspot. It appears as if one
level of indentation got lost.
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode96
aclocal.m4:96: true
Ditto, and many other lines in this file, too.
https://codereview.appspot.com/552770043/diff/574800043/configure.ac
File configure.ac (right):
https://codereview.appspot.com/552770043/diff/574800043/configure.ac#newcode286
configure.ac:286: STEPMAKE_GLIB(glib-2.0, REQUIRED,2.44)
I suggest a space before `2.44' here and in the next line.
https://codereview.appspot.com/552770043/
- Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by address@hidden),
lemzwerg <=