|
| From: | jonas . hahnfeld |
| Subject: | Re: Simplify mf-to-table (issue 549840043 by address@hidden) |
| Date: | Sat, 11 Apr 2020 09:12:52 -0700 |
Thanks for the cleanup, a few nits inline. (I assume the description wasn't updated according to your local commit text?) https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py File scripts/build/mf-to-table.py (right): https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py#newcode22 scripts/build/mf-to-table.py:22: import getopt I think this import can be dropped https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py#newcode165 scripts/build/mf-to-table.py:165: Regular expressions seem a bit overkill here. What about root = os.path.splitext (name) global_lisp_nm = root + '.global-lisp' char_lisp_nm = root + '.lisp' https://codereview.appspot.com/549840043/
| [Prev in Thread] | Current Thread | [Next in Thread] |