[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Simplify mf-to-table (issue 549840043 by address@hidden)
|
From: |
hanwenn |
|
Subject: |
Re: Simplify mf-to-table (issue 549840043 by address@hidden) |
|
Date: |
Sun, 12 Apr 2020 03:47:33 -0700 |
https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py
File scripts/build/mf-to-table.py (right):
https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py#newcode22
scripts/build/mf-to-table.py:22: import getopt
On 2020/04/11 16:12:52, hahnjo wrote:
> I think this import can be dropped
Done.
https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py#newcode165
scripts/build/mf-to-table.py:165:
On 2020/04/11 16:12:53, hahnjo wrote:
> Regular expressions seem a bit overkill here. What about
> root = os.path.splitext (name)
> global_lisp_nm = root + '.global-lisp'
> char_lisp_nm = root + '.lisp'
Done.
https://codereview.appspot.com/549840043/