[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-devel] Potential bug in commit 79d69ce5269a encode 'header off
|
From: |
address@hidden |
|
Subject: |
Re: [lwip-devel] Potential bug in commit 79d69ce5269a encode 'header offset' in 'enum pbuf_layer' |
|
Date: |
Thu, 22 Jun 2017 19:28:52 +0200 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
Axel Lin wrote:
PBUF_LINK_ENCAPSULATION_HLEN can be 0.
And *is*, most of the time.
Then we cannot differentiate the PBUF_RAW_TX and PBUF_RAW in switch/case.
This looks like a potential bug.
It's intentionally: pbuf_layer has never been stored any way but always
has been an allocation hint only (to calculate the header room / "offset").
This offset is now implicitly passed and if PBUF_RAW and PBUF_RAW_TX are
equal, that shouldn't be a problem.
(thought PBUF_RAW_TX is not used in
current code)
That's kind of odd...
Simon