[lwip-devel] [patch #9384] Partial SACK (RFC 2018) support

[Jakub Schmidtke]

Follow-up Comment #19, patch #9384 (project lwip):

OK, so to have a precalculated array/list/whatever of SACKs, it can either be
kept as an array in TCP PCB (current implementation), use memp pools, or
somehow be integrated with ooseq.

What is wrong with using memp? Assuming that SACKs are not that lightweight to
begin with.

If we want to avoid having dynamic memory allocation there, but want
precalculated SACKs, they have to be stored somewhere.
So it's either the current array, or inside tcp_seg in ooseq queue.
If they are stored in tcp_seg somehow (doesn't really matter how, even if it
was a single pointer - and potentially it would be more than that),
it means increased memory usage for every single tcp_seg structure.
Is using memp worse than increasing memory use of every single tcp_seg?

If both are too "heavy", maybe keeping the array is actually more lightweight
solution (since the memory cost is per TCP PCB, not per tcp_seg...)?


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9384>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/