lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9384] Partial SACK (RFC 2018) support


From: Simon Goldschmidt
Subject: [lwip-devel] [patch #9384] Partial SACK (RFC 2018) support
Date: Thu, 29 Jun 2017 14:18:39 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Follow-up Comment #20, patch #9384 (project lwip):

I see three problems using memp:
- users have to configure yet another pool
- memp allocation can fail (what do we do in thist case?)
- memp uses "sizeof(void*)" more bytes per region (typically 12 instead of 8
bytes per region)

Given that, personally I prefer the array solution as it is now. The code
looks simple enough to me, too.

>From my point of view, we can go ahead and push this patch (with the formal
changes I initially suggested, that is).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9384>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]