Re: lynx-dev [PATCH 2.8.3.dev6] patch that will prevent returning to the previous

[Vlad Harchev]

On Sun, 15 Aug 1999, Klaus Weide wrote:

> On Sun, 15 Aug 1999, Kim DeVaughn wrote:
> > On Fri, Aug 13, 1999, Vlad Harchev (address@hidden) said:
> > 
> > |  Will TEXTAREA_STOP_AT_LEFT_EDGE be ok as lynx.cfg setting? What do you
> > | suggest?
> > 
> > I haven't tried your patch, 
> 
> I haven't tried it either, but someone should figure out what it does
> before discussion of how to name the option to control it makes sense.

 Here is minimalistic patch that will unconditionally enable new behaviour
for those who wish to test this (to be applied to any version lynx):

diff -ru old/src/LYForms.c fixed/src/LYForms.c
--- old/src/LYForms.c   Sat Jul 31 04:38:15 1999
+++ fixed/src/LYForms.c Fri Aug 13 07:29:26 1999
@@ -627,7 +627,8 @@
                        c = HTConfirmDefault(PREV_DOC_QUERY, NO);
                    }
                    if (c == YES) {
-                       return(ch);
+                       /*return(ch);*/
+                       goto again;
                    } else {
                        if (form->disabled == YES)
                            _statusline(ARROWS_OR_TAB_TO_MOVE);
 
> It seems the
>      c = HTConfirmDefault(PREV_DOC_QUERY, NO); 
> which only gets triggered if the field has been changed during *this*
> line-editing "session" let's the user confirm "Yes, I want to go back
> to the previous document" and then that reply is ignored anyway.  This
> patch isn't usable as-is, unless I am overlooking something very basic.

 Yes, I overlooked this (that HTConfirmDefault(PREV_DOC_QUERY, NO) should be
avoided if the new behaviour is in effect, since the current document won't be
left). The patch (that should be applied over previous patch) is at the end of
this message.
 I ask Tom to add corresponding lynx.cfg setting to the table of settings in 
LYReadCFG.c (with XXX substituted with the name of the setting invented by
lynx developers).

PARSE_SET("XXX", CONF_BOOL, &textfield_stop_at_left_edge)

>[...] 

 Best regards,
  -Vlad

diff -ru old/src/LYForms.c fixed/src/LYForms.c
--- old/src/LYForms.c   Thu Aug 12 06:43:41 1999
+++ fixed/src/LYForms.c Fri Aug 13 07:37:17 1999
@@ -623,7 +623,7 @@
            case LTARROW:       /* 1999/04/14 (Wed) 15:01:33 */
                if (MyEdit.pos == 0 && repeat == -1) {
                    int c = YES;    /* Go back immediately if no changes */
-                   if (strcmp(MyEdit.buffer, value)) {
+                   if (sticky_inputs && !textfield_stop_at_left_edge && 
strcmp(MyEdit.buffer, value)) {
                        c = HTConfirmDefault(PREV_DOC_QUERY, NO);
                    }
                    if (c == YES) {