Re: lynx-dev bug fix needs fixing

[Leonid Pauzner]

26-Aug-99 07:18 T.E.Dickey wrote:
>> >> But by changing PERSISTENT_COOKIES to EXP_PERSISTENT_COOKIES in
>> >> LYMain (two places), this patch provokes the cookiefile name corruption
>> >> that was later fixed in the devel code.  In other words, the patch
>> >> introduces a new problem and cannot be recommended.
>> >>
>> >> The patch should be updated to also include the later correction that
                                  ^^^^^^^^^^^^^^^
>> >> is in the devel code (use StrAllocCopy for LYCookieFile_flag in
>> >> reload_read_cfg).
>> >>
>> >> The updated patch should also contain the change from my previous message
>> >> ('passwords should not be saved').
>>
>> > I updated this - made a new "fix2" file and changed the older version to 
>> > "fix".
>>
>> By this fix2 you revert EXP_PERSISTENT_COOKIES to PERSISTENT_COOKIES
>> so the discussed _flag became irrelevant at all - just ignored.

> yes (that was the way I understood Klaus' comment)

no. Look at reload_read_cfg()::LYMain.c from dev.6 -
use StrAllocCopy(LYCookieFile_flag) _within_ EXP_PERSISTENT_COOKIES

> --
> Thomas E. Dickey
> address@hidden
> http://www.clark.net/pub/dickey