lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev bug fix needs fixing


From: Klaus Weide
Subject: Re: lynx-dev bug fix needs fixing
Date: Thu, 26 Aug 1999 11:02:38 -0500 (CDT)

On Thu, 26 Aug 1999, T.E.Dickey wrote:

> > >> 
> > >> By this fix2 you revert EXP_PERSISTENT_COOKIES to PERSISTENT_COOKIES 
> > >> so the discussed _flag became irrelevant at all - just ignored. 
> >  
> > > yes (that was the way I understood Klaus' comment) 
> >  
> > no. Look at reload_read_cfg()::LYMain.c from dev.6 - 
> > use StrAllocCopy(LYCookieFile_flag) _within_ EXP_PERSISTENT_COOKIES 
> 
> I understood that - but my impression (Klaus will comment one way or another)
> was that there were some related changes that were not in the patch that were
> necessary to use that chunk of code.

No, Leonid is right, about what I meant.  I see why a diff would have
been better than a verbal patch, sorry.  (I just didn't have an unpacked
2.8.1 tree ready and not much space.)

It would be nice if you could update it yet again.  Otoh there are other
problems with cfg-reloading, this one change doesn't make that much of a
difference in making it generally usable.  (I think I have never tried
what happens if one changes the cookiefile and then reloads, with the
logic as now in the patch.  Cookies may get just written to the new
file instead of the old one from where they were read, which probably
isn't too bad - maybe even what should happen.)


   Klaus


reply via email to

[Prev in Thread] Current Thread [Next in Thread]