Re: lynx-dev problem with lynx 2.8.3dev.7

[pg]

In a recent note, T.E.Dickey said:

> Date: Thu, 26 Aug 1999 11:54:51 -0400 (EDT)
> 
> > "/home/lwv26/i/src/Unix/lynx/t/lynx2-8-3/src/LYOptions.c", line 915: 
> > warning: a cast does not yield an lvalue 
> 
> hmm (I have built this only with gcc - I suspect that taking off the "(char 
> *)"
> altogether will fix the symptom).  We had this once before.
> 
Indeed.  Here's a rework of yesterday's patch which entirely removes
the cast.  It also removes the definition of TYPECAST.  Editor's
choice -- TYPECAST may be among the submitter's favorite shortcuts,
but including everyone's favorite shortcut for one (now zero) applied
occurrence badly clutters the product.

-- gil
-- 
StorageTek
INFORMATION made POWERFUL
==============================================================================
%%% Created Fri Aug 27 15:42:05 MDT 1999 by target lynx.patch. %%%
diff -bru orig/lynx2-8-3/src/LYOptions.c lynx2-8-3/src/LYOptions.c
--- orig/lynx2-8-3/src/LYOptions.c      Thu Aug 26 05:31:19 1999
+++ lynx2-8-3/src/LYOptions.c   Fri Aug 27 14:30:22 1999
@@ -912,7 +912,7 @@
                            addstr(LYRawMode ? "ON " : "OFF");
                        }
                    }
-                   FREE(TYPECAST(char *,assume_list));
+                   FREE(assume_list);
                    response = ' ';
                    if (LYSelectPopups) {
 #if !defined(VMS) || defined(USE_SLANG)
diff -bru orig/lynx2-8-3/WWW/Library/Implementation/HTUtils.h 
lynx2-8-3/WWW/Library/Implementation/HTUtils.h
--- orig/lynx2-8-3/WWW/Library/Implementation/HTUtils.h Thu Aug 26 13:39:58 1999
+++ lynx2-8-3/WWW/Library/Implementation/HTUtils.h      Fri Aug 27 15:18:52 1999
@@ -287,12 +287,6 @@
 /* array/table size */
 #define        TABLESIZE(v)    (sizeof(v)/sizeof(v[0]))
 
-/* Quiet compiler warnings on places where we're being blamed incorrectly,
- * e.g., for casting away const, or for alignment problems.  It's always
- * legal to cast a pointer to long w/o loss of precision.
- */
-#define TYPECAST(type,ptr) (type*)((long)(ptr))
-
 #define        typecalloc(cast)                (cast *)calloc(sizeof(cast),1)
 #define        typecallocn(cast,ntypes)        (cast 
*)calloc(sizeof(cast),ntypes)