lzip-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lzip-bug] Re: Version 1.11-rc2 of lzip released


From: JonY
Subject: Re: [Lzip-bug] Re: Version 1.11-rc2 of lzip released
Date: Tue, 03 Aug 2010 07:52:19 +0800
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.0

On 8/3/2010 03:07, Elbert Pol wrote:
On 2-08-10 17:27, Antonio Diaz Diaz wrote:
JonY wrote:
This only applies to the older Cygwin 1.5, I think. Cygwin 1.7 now
uses binary IO only, text mode was dropped.

Great! Another step towards the disappearance of text mode.


Anyway, Cygwin versions builds and passes the test without any
changes. I tested with lzip-1.11-rc3-20100729.

Thanks. So this means lzip only need to be modified for native Windows
mode?


Exactly. So far its just the native msvcrt treating files as text mode.


Elbert Pol wrote:
Your also going to have to include io.h to pull in the setmode(),
then the tests pass.

The makefiles, configure and check.sh also need exeext added to
properly support OS/2 and Windows.

Thanks. Those are too many changes just to work around bugs and
shortcomings of two proprietary, non-posix OSs.

As my commitment is to provide high quality software for free posix
systems, I hope you both will be so kind to patch lzip for your
respective systems until those systems implement posix compatibility.

Hi Antonio,

Is seems i had the wrong place adding it :(
But now set @ :
@@ -643,6 +644,11 @@

int main( const int argc, const char * const argv[] )
{
+ #if defined(__OS2__) || defined(__CYGWIN__)
+ setmode( STDIN_FILENO, O_BINARY );
+ setmode( STDOUT_FILENO, O_BINARY );
+ #endif
+
// Mapping from gzip/bzip2 style 1..9 compression modes
// to the corresponding LZMA compression modes.
const Lzma_options option_mapping[] =

BTW: using __EMX__ Also works
Just OS2 or EMX don't work

Now lzip is passing the test :PP


Hi,

as noted above __CYGWIN__ is no longer needed. Use __MSVCRT__ instead for Windows.

Nice to know that OS/2 also passes the tests with the same trick.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]