Re: tarlz 0.16 build failure on FreeBSD 11.3

[Matias Fonzo]

Oops, I mean:

https://github.com/janestreet/core/pull/114/files

The other url seems to handle the BSD cases as:
... #elif defined(__FreeBSD__) || defined(__OpenBSD__) || 
defined(__NetBSD__) || defined(__DragonFly__)

El 2020-05-01 17:35, Matias Fonzo escribió:
> El 2020-05-01 13:09, Antonio Diaz Diaz escribió:
> > Hello David,
> >
> > David Glover-Aoki wrote:
> > > tarlz is not included in the FreeBSD ports so I'm trying to build it 
> > > from source, but I get the following error:
> > >
> > > c++ -O2 -c create.cc -o create.o
> > > create.cc:33:10: fatal error: 'sys/sysmacros.h' file not found
> > > #include<sys/sysmacros.h>               // for major, minor
> >
> > Thank you very much for reporting this. It seems that sys/sysmacros.h
> > is not part of POSIX, in spite of its macros being needed to
> > encode/decode device numbers in tar/pax archives, and some POSIX
> > systems do not provide it.
> >
> > Could you, please, try including sys/sysmacros.h conditionally in
> > create.cc and extract.cc like in the following example (or with other
> > macro suitable for FreeBSD), and tell me if it compiles. Thanks.
> >
> > #if !defined __FreeBSD__
> > #include <sys/sysmacros.h>              // for major, minor
> > #endif
>
> It seems that the major / minor / makedev are available through
> sys/types.h on some BSDs, I can't find a direct source of the
> information, yet.  But I am seeing some bug reports and changes like
> this[1].
>
> [1]
> https://stackoverflow.com/questions/35392291/how-to-convert-between-a-dev-t-and-major-minor-device-numbers/35392350