[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] input: recognize the start and stop sequences of a brack
From: |
Brand Huntsman |
Subject: |
Re: [PATCH 1/2] input: recognize the start and stop sequences of a bracketed paste |
Date: |
Fri, 10 Jan 2020 19:03:07 -0700 |
On Fri, 10 Jan 2020 15:56:13 +0100
Benno Schulenberg <address@hidden> wrote:
> > + if (*kbinput != 0x9 && *kbinput != 0xA && *kbinput != 0xD)
>
> Why is 0x0A allowed to pass through? Although a paste should normally
> not contain any linefeeds, if one does, it would result in justifying
> the current paragraph, which is unwanted behavior when pasting.
I thought LF was used and added CR so it could be pasted into a DOS/MAC
file. But it appears terminals convert LF to CR in pastes
(https://security.stackexchange.com/a/52655).
> > @@ -1323,6 +1338,8 @@ void regenerate_screen(void)
> >
> > + disable_bracketed_paste();
> > +
> > terminal_init();
>
> Is switching off bracketed-paste mode needed here? Because
> terminal_init() switches it on again.
Removing it seems to work fine when pasting after resizing urxvt. I was being
safe by disabling it, in case a terminal didn't like it being enabled while
already enabled.
- [PATCH 1/2] input: recognize the start and stop sequences of a bracketed paste, Benno Schulenberg, 2020/01/05
- [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Benno Schulenberg, 2020/01/05
- Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Brand Huntsman, 2020/01/06
- Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Benno Schulenberg, 2020/01/06
- Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Brand Huntsman, 2020/01/06
- Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Benno Schulenberg, 2020/01/07
- Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Brand Huntsman, 2020/01/07
- Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Benno Schulenberg, 2020/01/08
Re: [PATCH 2/2] input: do not auto-indent when something is pasted into nano from outside, Benno Schulenberg, 2020/01/10
Re: [PATCH 1/2] input: recognize the start and stop sequences of a bracketed paste, Benno Schulenberg, 2020/01/10
- Re: [PATCH 1/2] input: recognize the start and stop sequences of a bracketed paste,
Brand Huntsman <=