Re: [Nmh-workers] Announcing the second release candidate of nmh 1.7.1

[Andy Bradford]

Thus said David Levine on Tue, 23 Jan 2018 07:45:29 -0500:

> I usually cheat and just run the test directly:
> 
>     test/ali/test-ali

Ok, I'll give that a try. Interestingly:

$ make check TESTS=test/mhshow/test-charset
make  test/fakehttp test/fakepop  test/fakesmtp test/getcanon  test/getcwidth 
test/getfullname  test/runpty test/common.sh
`test/fakehttp' is up to date.
`test/fakepop' is up to date.
`test/fakesmtp' is up to date.
`test/getcanon' is up to date.
`test/getcwidth' is up to date.
`test/getfullname' is up to date.
`test/runpty' is up to date.
`test/common.sh' is up to date.
make  check-TESTS
...
first named test failure: replacement character in parameter value
FAIL: test/mhshow/test-charset
=======================================
1 of 1 test failed
Please report to address@hidden
=======================================
*** Error 1 in . (Makefile:4853 'check-TESTS': @failed=0; all=0; xfail=0; 
xpass=0; skip=0;  srcdir=.; export srcdir;  list=' test/mhshow/tes...)
*** Error 1 in /tmp/nmh-1.7.1-RC2 (Makefile:5020 'check-am')

Let's see what failed:

$ ls test/testdir/
19455.actual    19455.expected  inst/
$ diff test/testdir/19455.*; echo $?
0
$ md5 test/testdir/19455.*
MD5 (test/testdir/19455.actual) = cc15d943cbe66365f49268516f99e00c
MD5 (test/testdir/19455.expected) = cc15d943cbe66365f49268516f99e00c
$ cat test/testdir/19455.expected
[ Message inbox:12 ]
Subject: invalid parameter value charset

MIME-Version: 1.0

[ part  - text/plain -   0B  ]

So why is  this test failing? Maybe I misunderstand  the significance of
these files and how they're used. Time to do some more digging...

$ test/mhshow/test-charset 
first named test failure: replacement character in parameter value
$ echo $?
1

And with -x:

+ [ 0 -eq 1 ]
+ grep Can't convert .*us-ascii to UTF-8 
/tmp/nmh-1.7.1-RC2/test/testdir/38552.actual
+ > /dev/null 
+ failed=1

So it's entering this:

if [ $iconv_elides_question_marks -eq 1 ]; then
    check "$expected" "$actual"
else
    grep "Can't convert .*us-ascii to UTF-8" "$actual" >/dev/null  ||  failed=1
fi

Is it not honoring the locale: setting in .mh_profile?

And I'm out of time, so I'll have to look into it more tomorrow.

Thanks,

Andy
-- 
TAI64 timestamp: 400000005a6820a8