Re: [Nmh-workers] Where are we at for 1.7.1?

[Andy Bradford]

Thus said Ralph Corderoy on Tue, 30 Jan 2018 17:01:58 +0000:

> That's  this  early   part.  Does  it  attempt  the   printf?  If  so,
> $ICONV_ENABLED  isn't  0,  and   iconv(1)  quite  reasonably  disliked
> converting from `?UTF-8'.

No, it does  not attempt the printf because ICONV_ENABLED=0  and I'm not
even sure what is supposed to alter  ICONV_ENABLED (I ran with sh -x and
only ever  see it accessed  once). I don't see  it anywhere in  the test
case in question, nor do I see it being set in test/common.sh.

> > $ cat $MHTMPDIR/inbox/$msgnum                                     
> > Subject: invalid parameter value charset
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset*=invalid''%0Dus-ascii
> 
> It expects  an error because  the charset is invalid.  The parameter's
> value is in  the `invalid' character set, with  no specified language,
> and it is a carriage return followed by `us-ascii'.

So,  even though  $actual and  $expected  are identical,  the output  is
incorrect in both?  That doesn't seem correct; rather, it  would seem to
me that if  ICONV_ENABLED=0 that the output is  actually correct output,
and that inspecting iconv_elides_question_marks is the wrong thing to do
(at least in this environment).  Accordingly, I just tried the following
and now the test passes:

$ diff -u test/mhshow/test-charset.orig test/mhshow/test-charset    
--- test/mhshow/test-charset.orig       Thu Jan 18 18:23:34 2018
+++ test/mhshow/test-charset    Tue Jan 30 13:40:48 2018
@@ -144,7 +144,7 @@
 EOF
 
 run_prog mhshow $msgnum > $actual 2>&1
-if [ $iconv_elides_question_marks -eq 1 ]; then
+if [ $ICONV_ENABLED -eq 0 -o $iconv_elides_question_marks -eq 1 ]; then
     check "$expected" "$actual"
 else
     grep "Can't convert .*us-ascii to UTF-8" "$actual" >/dev/null  ||  failed=1

However, I'm not certain if that's the right thing to do here, but ti 
does pass:

$ make TESTS=test/mhshow/test-charset check
make  test/fakehttp test/fakepop  test/fakesmtp test/getcanon  test/getcwidth 
test/getfullname  test/runpty test/common.sh
`test/fakehttp' is up to date.
`test/fakepop' is up to date.
`test/fakesmtp' is up to date.
`test/getcanon' is up to date.
`test/getcwidth' is up to date.
`test/getfullname' is up to date.
`test/runpty' is up to date.
`test/common.sh' is up to date.
make  check-TESTS
PASS: test/mhshow/test-charset
=============
1 test passed
=============

Thanks,

Andy
-- 
TAI64 timestamp: 400000005a70d9d6