valgrind Complaint for test/mhshow/test-charset.

[Ralph Corderoy]

Hi,

I'm getting a repeatable valgrind(1) complaint with

    NMH_VALGRIND=1 make TESTS=test/mhshow/test-charset check

on one machine but not the other.  Both are x86_64 but with different
C libraries, etc.

I think it's

    start_test 'Encoded parameter value'

with the interesting, repetitive, bit of valgrind:

     ==19813551992192== Invalid read of size 8
     ==19813551992192==    at 0x4024AC0: strncmp (strcmp-sse2.S:160)
     ==19813551992192==    by 0x4004EBF: is_dst (dl-load.c:216)
    ...
     ==19813551992192==    by 0x4923707: iconv_open (iconv_open.c:39)
     ==19813551992192==    by 0x116A93: get_param_value (mhparse.c:3957)
     ==19813551992192==    by 0x116D54: get_param (mhparse.c:3906)
     ==19813551992192==    by 0x116D54: content_charset (mhparse.c:3433)
     ==19813551992192==    by 0x1184B7: convert_content_charset 
(mhshowsbr.c:1264)
     ==19813551992192==    by 0x1184B7: show_content_aux (mhshowsbr.c:373)
     ==19813551992192==    by 0x1186B7: show_text (mhshowsbr.c:551)
     ==19813551992192==    by 0x118E19: show_single_message (mhshowsbr.c:178)
     ==19813551992192==    by 0x119135: show_all_messages (mhshowsbr.c:141)
     ==19813551992192==    by 0x10F147: main (mhshow.c:404)
     ==19813551992192==  Address 0x4b80161 is 1 bytes inside a block of size 8 
alloc'd
     ==19813551992192==    at 0x4841888: malloc (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
     ==19813551992192==    by 0x40248AE: malloc (rtld-malloc.h:56)
     ==19813551992192==    by 0x40248AE: strdup (strdup.c:42)
     ==19813551992192==    by 0x40063D4: decompose_rpath (dl-load.c:629)
    ...
     ==19813551992192==    by 0x4923707: iconv_open (iconv_open.c:39)
     ==19813551992192==    by 0x116A93: get_param_value (mhparse.c:3957)
     ==19813551992192==    by 0x116D54: get_param (mhparse.c:3906)
     ==19813551992192==    by 0x116D54: content_charset (mhparse.c:3433)
     ==19813551992192==    by 0x1184B7: convert_content_charset 
(mhshowsbr.c:1264)
     ==19813551992192==    by 0x1184B7: show_content_aux (mhshowsbr.c:373)
     ==19813551992192==    by 0x1186B7: show_text (mhshowsbr.c:551)
     ==19813551992192==    by 0x118E19: show_single_message (mhshowsbr.c:178)
     ==19813551992192==    by 0x119135: show_all_messages (mhshowsbr.c:141)
     ==19813551992192==    by 0x10F147: main (mhshow.c:404)

It looks to me like the problem lies outside of nmh but I'm wary since
that way lies ‘It's a compiler bug!’ so I thought I'd share with the
list.

-- 
Cheers, Ralph.