Re: valgrind Complaint for test/mhshow/test-charset.

[David Levine]

Ralph wrote:

> I'm getting a repeatable valgrind(1) complaint with
>
>     NMH_VALGRIND=1 make TESTS=test/mhshow/test-charset check
>
> on one machine but not the other.  Both are x86_64 but with different
> C libraries, etc.

I don't get that complaint here, Fedora 37 with glibc 2.36.

> I think it's
>
>     start_test 'Encoded parameter value'
>
> with the interesting, repetitive, bit of valgrind:
>
>      ==19813551992192== Invalid read of size 8
>      ==19813551992192==    at 0x4024AC0: strncmp (strcmp-sse2.S:160)
>      ==19813551992192==    by 0x4004EBF: is_dst (dl-load.c:216)
>     ...
>      ==19813551992192==    by 0x4923707: iconv_open (iconv_open.c:39)

I would think that would be suppressed by this in test/valgrind.supp:

{
   iconv_open on Fedora 33
   Memcheck:Addr16
   fun:strncmp
   ...
   fun:iconv_open
}

Even with that suppression removed, I don't see the complaint.

And it's clean for me on a non-debug build with all of the compiler
checks that build_nmh enables.

David