|
From: | Rik |
Subject: | [Octave-bug-tracker] [bug #49718] Octave crashes on print/saveas etc when installed on a directory with parenthesis |
Date: | Mon, 28 Nov 2016 22:12:23 +0000 (UTC) |
User-agent: | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 |
Update of bug #49718 (project octave): Status: Need Info => Confirmed _______________________________________________________ Follow-up Comment #7: I'm adding John D. to the CC list since he does most of the work on the MXE installer. There is a function for the Windows installer which checks for spaces in the name and alerts the user that this is a bad idea. A simple partial solution would be to extend this function to check for other questionable characters and throw up the same dialog box. The function is located in the MXE repository in the file tools/makeinst-script.sh.in. The code itself is: ; Check whether prev install is here and no spaces in dest name Function CheckPrevInstallAndDest IfFileExists "\$INSTDIR\\bin\\octave.exe" inst_exists inst_none inst_exists: MessageBox MB_YESNO|MB_ICONEXCLAMATION "Another Octave installation has been detected at that destination. It is recommended to uninstall it if you intend to use the same installation directory. Do you want to proceed with the installation anyway?" IDYES inst_none IDNO 0 Abort GoTo inst_end inst_none: ; check for spaces in dest filename Push \$R0 Push \$R1 StrCpy \$R1 0 # r1 = counter space_loop: StrCpy \$R0 \$INSTDIR 1 \$R1 # R0 = character in string to check StrCmp \$R0 "" space_end # end of string StrCmp \$R0 " " space_found IntOp \$R1 \$R1 + 1 GoTo space_loop space_found: MessageBox MB_OK|MB_ICONEXCLAMATION "Octave should not be installed to a destination folder containing spaces. Please select another destination." Abort space_end: Pop \$R1 Pop \$R0 inst_end: FunctionEnd _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?49718> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |