[Octave-bug-tracker] [bug #60750] Variable Editor changes docking state when 'openvar'-ring a variable

[John W. Eaton]

Follow-up Comment #9, bug #60750 (project octave):

The attached change almost works for me.  I added a flag to the dock widget to
allow checking whether a dock widget already exists when the main window is
created.  Then that flag is used to avoid docking widgets that already exist
and are adopted by the main window.

But I don't quite get what I was expecting when I try to reset the default
layout using the Window -> Reset default layout menu item when there is an
adopted dock widget, even though I tried to make that work by adding a "force"
option.

And openvar from the GUI command window now creates both a floating and docked
widget?!?  That was a surprise.

Anyway, this change shows what I was thinking about by adding a flag to
determine whether a dock widget existed before the main_window was created,
but there are a lot of interactions here, and I don't fully understand the use
of setFloating, especially here in octave_dock_widget::make_window:


    // the widget has to be reparented (parent = 0), preferably
    // from a non-toplevel widget otherwise may not have full
    // decorations, e.g., no taskbar icon and always in front
    if (isFloating ())
      setFloating (false);


Why would we set the floating property to false here?  That doesn't seem to
match with making a window and the comment doesn't help me understand.

(file #51538)
    _______________________________________________________

Additional Item Attachment:

File name: dock-widget-adoption-diffs.txt Size:11 KB
   
<https://file.savannah.gnu.org/file/dock-widget-adoption-diffs.txt?file_id=51538>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60750>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/