[Octave-bug-tracker] [bug #61024] [mxe-octave] build-markupsafe fails to build if build-python3 is built without libffi

[John W. Eaton]

Follow-up Comment #10, bug #61024 (project octave):

After looking at my build (not one of the buildbots) I noticed this problem in
the build-python3 log file:


gcc -pthread -fPIC -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3
-Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter
-Wno-missing-field-initializers -Werror=implicit-function-declaration
-I/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/Include/internal
-I/scratch/build/mxe-octave-w64/default/usr/x86_64-w64-mingw32/include -I.
-I/scratch/build/mxe-octave-w64/default/usr/include -IObjects -IPython
-I/usr/include/x86_64-linux-gnu -I/usr/local/include
-I/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/Include
-I/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/.build
-c
/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/Modules/_ctypes/_ctypes.c
-o
build/temp.linux-x86_64-3.8/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/Modules/_ctypes/_ctypes.o
In file included from
/scratch/build/mxe-octave-w64/default/usr/x86_64-w64-mingw32/include/corecrt.h:10,
                 from
/scratch/build/mxe-octave-w64/default/usr/x86_64-w64-mingw32/include/crtdefs.h:10,
                 from
/scratch/build/mxe-octave-w64/default/usr/x86_64-w64-mingw32/include/limits.h:6,
                 from
/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/Include/Python.h:11,
                 from
/scratch/build/mxe-octave-w64/default/tmp-build-python3/Python-3.8.3/Modules/_ctypes/_ctypes.c:104:
/scratch/build/mxe-octave-w64/default/usr/x86_64-w64-mingw32/include/_mingw.h:272:2:
error: #error Only Win32 target is supported!
  272 | #error Only Win32 target is supported!
      |  ^~~~~


I was not expecting to see
"-I/scratch/build/mxe-octave-w64/default/usr/x86_64-w64-mingw32/include" in
the compiler flags when building a native build tool.  If I understand
correctly, this is happening because the python3 configure script is using the
pkg-config program that we build to tell us what -I option we should use to
find libffi headers.  But by default our pkg-config program looks for .pc
files in directories that are appropriate for the cross built packages, not
the native ones.  We try to fix that up in the build-*.mk files where needed
by using "PKG_CONFIG_PATH='$(BUILD_PKG_CONFIG_PATH)'" on the configure command
line, but the value of BUILD_PKG_CONFIG_PATH is set in the mxe-octave
configure script before we build the build-pkg-config program.

I checked in the following change but I'm not sure it is the best solution.

https://hg.octave.org/mxe-octave/rev/4e1ae8cbc9ec

Let's see if this helps with the buildbots.  If not, I'll take another look.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61024>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/