[Octave-bug-tracker] [bug #64778] VM: test anovan crashes octave

[Petter]

Follow-up Comment #7, bug #64778 (project octave):

Thanks for the tests. I think I have a patch that solves the issues (The tests
passes). The main issue was that the VM could not handle the call to
break_closure_cycles() properly for nested frames.


Don't clone nil values when breaking closure cycles on VM stack (bug #64778)

Breaking closure cycles caused nil values (the nilrep octave_base_value) to
clone itself and not have the same pointer representation, which caused
internal
VM checks checking for nil values to fail.

Also, remove bad use of is_closure_context().

* libinterp/corefcn/stack-frame.cc: Not for nil values. Remove closeure
check.
* libinterp/parse-tree/pt-bytecode-vm.cc: Print nested vars mapping with
bytecode
                                          Don't stash shared frame pointers
that are
                                          closure contexts.
* test/compile/bytecode_nested.m: Update tests


(file #55248)

    _______________________________________________________

Additional Item Attachment:

File name: octave_32530.patch             Size:7 KB
    <https://file.savannah.gnu.org/file/octave_32530.patch?file_id=55248>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64778>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/