Re: [paragui-users] Tiny detail about the PopupMenu.

[Andrew Ford]

Maybe we should do a code review before 1.2, and make
up a list of things to check.  Const correctness is
one thing.  I'd also like to examine the API for
inconsistencies, since we're going to be breaking
compatibility anyway.  What else can we review in such
things?

Andrew.

--- Guillaume Schmid <address@hidden> wrote:
> Le mar 18/06/2002 à 19:01, Andrew Ford a écrit :
> > Yes, you're right.  I'd change it if I had cvs
> access,
> > but my computer has again been broken in the mail.
> 
> > This sucks.  Anyway, I'm sure Alex will fix this.
> That would be cool!
> 
> I noticed the same problem with addMenuItem.
> 
> a++
> Guillaume.
> 
> 
> > 
> > Andrew.
> > 
> > --- Guillaume Schmid <address@hidden> wrote:
> > > Hello,
> > > 
> > > I just noticed a small thing int the creation
> method
> > > of the PopupMenu
> > > creator: it is :
> > > 
> > > PG_PopupMenu(PG_Widget *parent, int x, int y,
> char
> > > *caption, char 
> > >           *style= "PopupMenu");                         
>    
> > >   
> > > 
> > > And the caption parameter is used only to
> initialize
> > > a std::string like
> > > this:
> > > if(caption != NULL) {
> > >    myCaption = caption;
> > > }
> > > 
> > > Except if I missed some (probably obvious)
> point,
> > > this parameter could
> > > be a const (it could even be a string but...).
> > > In fact since it is not const, you cannot give a
> > > string::c_str() as a
> > > parameter for instance, and in certain cases, it
> > > could be annoying.
> > > Is this possible to change this ?
> > > 
> > > Well, that's all,
> > > 
> > > Thank you for your attention.
> > > 
> > > a++
> > > Guillaume.
> > > 
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > paragui-users mailing list
> > > address@hidden
> > >
> >
>
http://mail.freesoftware.fsf.org/mailman/listinfo/paragui-users
> > 
> > 
> > __________________________________________________
> > Do You Yahoo!?
> > Yahoo! - Official partner of 2002 FIFA World Cup
> > http://fifaworldcup.yahoo.com
> > 
> > _______________________________________________
> > paragui-users mailing list
> > address@hidden
> >
>
http://mail.freesoftware.fsf.org/mailman/listinfo/paragui-users
> > 
> 
> 
> 
> 
> _______________________________________________
> paragui-users mailing list
> address@hidden
>
http://mail.freesoftware.fsf.org/mailman/listinfo/paragui-users


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com