[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pickles: Add mbr.pk for MBR partition table
From: |
Mohammad-Reza Nabipoor |
Subject: |
Re: [PATCH] pickles: Add mbr.pk for MBR partition table |
Date: |
Tue, 26 Jan 2021 11:10:50 +0330 |
On Tue, Jan 26, 2021 at 08:05:45AM +0100, Jose E. Marchesi wrote:
>
> type MBR = struct
> {
> byte[440#B] bootstrap;
> uint32 signature;
> byte[2] reserved = [0x0UB,0x0UB];
> MBR_PTE[4] pte;
> byte[2] magic = [0x55UB,0xaaUB];
> };
>
> Checking that `reserved' is [0x0,0x0] is necessary anyway in this case,
> isnt it?
I agree with giving it a name.
And as we discussed in IRC, it seems there's no agreement on the meaning
of this field so let's declare it without any constraint.
And I'm happy that I declared it unnamed mistakenly :)
It revealed a bug!