poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] poke.el: update protocol in `poke-complete-handle-cmd'


From: Jose E. Marchesi
Subject: Re: [PATCH] poke.el: update protocol in `poke-complete-handle-cmd'
Date: Mon, 05 Dec 2022 16:08:08 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Mohammad.

Thanks for the patch.
OK.

> ---
>
> Hi Jose.
>
> I don't know how to enable auto-completion on my Emacs, so please
> verify this change :)
>
> This changes the protocol to sandwich the message inside a
> ITER_BEGIN/ITER_END.
>
>
> Regards,
> Mohammad-Reza
>
>  poke.el | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/poke.el b/poke.el
> index 4c91009..b8dd85f 100644
> --- a/poke.el
> +++ b/poke.el
> @@ -709,7 +709,11 @@ buffer."
>  
>  (defun poke-complete-handle-cmd (proc cmd data)
>    (pcase cmd
> -    (1 ; Complete identifier: variable, type, function, unit.
> +    (1 ; Completion iteration begin.  Unused
> +     )
> +    (2 ; Completion iteration end.  Unused
> +     )
> +    (4 ; Complete identifier: variable, type, function, unit.
>       (let ((alternatives nil))
>         (with-current-buffer (process-buffer proc)
>           (delete-region (point-min) (point-max))
> @@ -734,7 +738,7 @@ buffer."
>             (completion-in-region poke-repl-complete-begin
>                                   poke-repl-complete-end
>                                   poke-complete-alternatives)))))
> -    (2 ; Complete IO space.  Unused
> +    (5 ; Complete IO space.  Unused
>       )
>      (_ ;; Protocol error
>       (process-put proc 'pokelet-buf "")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]