[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: file-handles'
From: |
John Darrington |
Subject: |
Re: file-handles' |
Date: |
Mon, 23 Jan 2006 09:15:43 +0800 |
User-agent: |
Mutt/1.5.9i |
On Sun, Jan 22, 2006 at 04:58:52PM -0800, Ben Pfaff wrote:
John Darrington <address@hidden> writes:
> Frankly, the only reason the GUI needs to bother with file_handles, is
> that it's currently the only way to call sfm_open_{reader,writer}.
> I'd be happier to add a function to these modules, which takes a
> filename instead of a file_handle (and the same for pfm_open). Then
> I don't need to use file handles at all.
>
> Do you think that would be a better solution?
It sounds reasonable too. You'll need to replace a lot of calls
to fh_get_filename() by a saved copy of the filename, but that
might actually qualify as a clean-up. Do make sure to preserve
the pairing of fh_open() and fh_close(), even in error
cases.
I'll do that later this week then.
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature
- file-handles, John Darrington, 2006/01/21
- Re: file-handles, Ben Pfaff, 2006/01/22
- Re: file-handles, John Darrington, 2006/01/22
- Re: file-handles, Ben Pfaff, 2006/01/22
- Re: file-handles, John Darrington, 2006/01/22
- Re: file-handles, Ben Pfaff, 2006/01/22
- Re: file-handles, John Darrington, 2006/01/22
- Re: file-handles, Ben Pfaff, 2006/01/22
- Re: file-handles',
John Darrington <=