[patch #6452] Fix VARIABLE WIDTH command and add test

[Ben Pfaff]

Follow-up Comment #1, patch #6452 (project pspp):

Via IRC:

jmd: Your patch doesn't appear to add the test to automake.mk
blp: No?  I must have failed to refresh the patch before I uploaded it.  That
was the last thing I added to it.
jmd: Why is the width a long ?
jmd: Surely we're not expecting variables more than 2^32 chars long :)
blp: Only because lex_integer() returns a long.
blp: I can make it an int if you feel more comfortable; same bug either way.
jmd: I guess it makes no difference really.
blp: We don't check that the width is a positive integer, for that matter.
jmd: Maybe we should do that.
blp: I'll happily add the check.
blp: And perhaps I should put in an upper limit as well?  Perhaps MAX_STRING
* 2.
blp: I don't know how well GTK+ would take to a column of width 2^31.
jmd: OK.
jmd: The GUI sets the limit at 255
jmd: I wonder if there was a good reason for that figure?
blp: The comment "Is this a sensible value ?" would imply that there was
not.
jmd: Hmm yes.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6452>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/