Re: [Qemu-arm] [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e180eb0b18 mps2-an505: New board model: MPS2 with AN505 Cortex-M33 FPGA image
e9d9691d66 hw/arm/iotkit: Model Arm IOT Kit
71a5d961f5 hw/misc/iotkit-secctl: Add remaining simple registers
4343d21683 hw/misc/iotkit-secctl: Add handling for PPCs
59b4605d5b hw/misc/iotkit-secctl: Arm IoT Kit security controller initial 
skeleton
73cfb2ca15 hw/misc/tz-ppc: Model TrustZone peripheral protection controller
36338baf4d hw/misc/mps2-fpgaio: FPGA control block for MPS2 AN505
b5a8b9e25d hw/core/split-irq: Device that splits IRQ lines
e28c0c384a qdev: Add new qdev_init_gpio_in_named_with_opaque()
92a11b2fb0 include/hw/or-irq.h: Add missing include guard
861290d23d hw/misc/unimp: Move struct to header file
cdd841df46 target/arm: Add Cortex-M33
94ad7cd114 armv7m: Forward init-svtor property to CPU object
f5c67afec5 target/arm: Define init-svtor property for the reset secure VTOR 
value
1e54044ac4 armv7m: Forward idau property to CPU object
8d2edaf899 target/arm: Define an IDAU interface
3a8d8926c5 hw/arm/armv7m: Honour CPU's address space for image loads
2a05095d98 hw/arm/boot: Honour CPU's address space for image loads
e365ccf88b loader: Add new load_ramdisk_as()

=== OUTPUT BEGIN ===
Checking PATCH 1/19: loader: Add new load_ramdisk_as()...
Checking PATCH 2/19: hw/arm/boot: Honour CPU's address space for image loads...
Checking PATCH 3/19: hw/arm/armv7m: Honour CPU's address space for image 
loads...
Checking PATCH 4/19: target/arm: Define an IDAU interface...
Checking PATCH 5/19: armv7m: Forward idau property to CPU object...
Checking PATCH 6/19: target/arm: Define init-svtor property for the reset 
secure VTOR value...
Checking PATCH 7/19: armv7m: Forward init-svtor property to CPU object...
Checking PATCH 8/19: target/arm: Add Cortex-M33...
Checking PATCH 9/19: hw/misc/unimp: Move struct to header file...
Checking PATCH 10/19: include/hw/or-irq.h: Add missing include guard...
Checking PATCH 11/19: qdev: Add new qdev_init_gpio_in_named_with_opaque()...
Checking PATCH 12/19: hw/core/split-irq: Device that splits IRQ lines...
Checking PATCH 13/19: hw/misc/mps2-fpgaio: FPGA control block for MPS2 AN505...
Checking PATCH 14/19: hw/misc/tz-ppc: Model TrustZone peripheral protection 
controller...
Checking PATCH 15/19: hw/misc/iotkit-secctl: Arm IoT Kit security controller 
initial skeleton...
WARNING: line over 80 characters
#530: FILE: include/hw/misc/iotkit-secctl.h:14:
+ * 
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ecm0601256/index.html

total: 0 errors, 1 warnings, 513 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/19: hw/misc/iotkit-secctl: Add handling for PPCs...
Checking PATCH 17/19: hw/misc/iotkit-secctl: Add remaining simple registers...
Checking PATCH 18/19: hw/arm/iotkit: Model Arm IOT Kit...
WARNING: line over 80 characters
#660: FILE: include/hw/arm/iotkit.h:13:
+ * 
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ecm0601256/index.html

total: 0 errors, 1 warnings, 718 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/19: mps2-an505: New board model: MPS2 with AN505 Cortex-M33 
FPGA image...
ERROR: line over 90 characters
#54: FILE: hw/arm/mps2-tz.c:21:
+ * 
https://developer.arm.com/products/system-design/development-boards/fpga-prototyping-boards/mps2

ERROR: line over 90 characters
#57: FILE: hw/arm/mps2-tz.c:24:
+ * 
http://infocenter.arm.com/help/topic/com.arm.doc.100112_0200_06_en/versatile_express_cortex_m_prototyping_systems_v2m_mps2_and_v2m_mps2plus_technical_reference_100112_0200_06_en.pdf

WARNING: line over 80 characters
#63: FILE: hw/arm/mps2-tz.c:30:
+ *   
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ecm0601256/index.html

total: 2 errors, 1 warnings, 510 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden