[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] exynos4210_pwm: Use ptimer_free() in the finalize function t
From: |
Gan Qixin |
Subject: |
[PATCH 4/7] exynos4210_pwm: Use ptimer_free() in the finalize function to avoid memleaks |
Date: |
Fri, 27 Nov 2020 15:18:00 +0800 |
When running device-introspect-test, a memory leak occurred in the
exynos4210_pwm_init
function, so use ptimer_free() in the finalize function to avoid it.
ASAN shows memory leak stack:
Indirect leak of 240 byte(s) in 5 object(s) allocated from:
#0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0)
#1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800)
#2 0xaaabf555db84 in timer_new_full /qemu/include/qemu/timer.h:523
#3 0xaaabf555db84 in timer_new /qemu/include/qemu/timer.h:544
#4 0xaaabf555db84 in timer_new_ns /qemu/include/qemu/timer.h:562
#5 0xaaabf555db84 in ptimer_init /qemu/hw/core/ptimer.c:433
#6 0xaaabf56a36cc in exynos4210_pwm_init /qemu/hw/timer/exynos4210_pwm.c:401
#7 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515
#8 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729
#9 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds.c:153
#10 0xaaabf653d8ec in qmp_marshal_device_list_properties
/qemu/qapi/qapi-commands-qdev.c:59
#11 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110
#12 0xaaabf6552708 in aio_bh_call /qemu/util/async.c:136
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
---
hw/timer/exynos4210_pwm.c | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/hw/timer/exynos4210_pwm.c b/hw/timer/exynos4210_pwm.c
index de181428b4..4764164d5e 100644
--- a/hw/timer/exynos4210_pwm.c
+++ b/hw/timer/exynos4210_pwm.c
@@ -410,6 +410,16 @@ static void exynos4210_pwm_init(Object *obj)
sysbus_init_mmio(dev, &s->iomem);
}
+static void exynos4210_pwm_finalize(Object *obj)
+{
+ Exynos4210PWMState *s = EXYNOS4210_PWM(obj);
+ int i;
+
+ for (i = 0; i < EXYNOS4210_PWM_TIMERS_NUM; i++) {
+ ptimer_free(s->timer[i].ptimer);
+ }
+}
+
static void exynos4210_pwm_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -419,11 +429,12 @@ static void exynos4210_pwm_class_init(ObjectClass *klass,
void *data)
}
static const TypeInfo exynos4210_pwm_info = {
- .name = TYPE_EXYNOS4210_PWM,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_size = sizeof(Exynos4210PWMState),
- .instance_init = exynos4210_pwm_init,
- .class_init = exynos4210_pwm_class_init,
+ .name = TYPE_EXYNOS4210_PWM,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_size = sizeof(Exynos4210PWMState),
+ .instance_init = exynos4210_pwm_init,
+ .instance_finalize = exynos4210_pwm_finalize,
+ .class_init = exynos4210_pwm_class_init,
};
static void exynos4210_pwm_register_types(void)
--
2.23.0
- [PATCH 0/7] Fix some memleaks caused by ptimer_init, Gan Qixin, 2020/11/27
- [PATCH 5/7] exynos4210_rtc: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 7/7] musicpal: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 1/7] allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 4/7] exynos4210_pwm: Use ptimer_free() in the finalize function to avoid memleaks,
Gan Qixin <=
- [PATCH 3/7] exynos4210_mct: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 2/7] digic-timer: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 6/7] mss-timer: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27