Re: [PATCH v5 3/6] hw/adc: Add an ADC module for NPCM7XX

[Peter Maydell]

On Fri, 8 Jan 2021 at 19:10, Hao Wu <wuhaotsh@google.com> wrote:
>
> The ADC is part of NPCM7XX Module. Its behavior is controled by the
> ADC_CON register. It converts one of the eight analog inputs into a
> digital input and stores it in the ADC_DATA register when enabled.
>
> Users can alter input value by using qom-set QMP command.
>
> Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com>
> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
>  docs/system/arm/nuvoton.rst    |   2 +-
>  hw/adc/meson.build             |   1 +
>  hw/adc/npcm7xx_adc.c           | 301 ++++++++++++++++++++++++++
>  hw/adc/trace-events            |   5 +
>  hw/arm/npcm7xx.c               |  24 ++-
>  include/hw/adc/npcm7xx_adc.h   |  69 ++++++
>  include/hw/arm/npcm7xx.h       |   2 +
>  meson.build                    |   1 +
>  tests/qtest/meson.build        |   3 +-
>  tests/qtest/npcm7xx_adc-test.c | 377 +++++++++++++++++++++++++++++++++

Adding trace events to a directory for the first time
requires also adding the hw/adc/trace.h file (which just has
a single line '#include "trace/trace-hw_adc.h"'), otherwise
this doesn't compile. I think that's the only issue with this
patchset, though, so I'll just fix it up locally.

(Stefan is going to send a patch fixing docs/devel/tracing.txt,
which failed to mention the need for this step when adding
a new subdir to tracing.)

thanks
-- PMM