[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface |
Date: |
Fri, 20 Oct 2023 15:03:27 +0200 |
Factor reset code out of the DeviceRealize() handler.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/pxa2xx_pic.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw/arm/pxa2xx_pic.c b/hw/arm/pxa2xx_pic.c
index 47132ab982..2eb869a605 100644
--- a/hw/arm/pxa2xx_pic.c
+++ b/hw/arm/pxa2xx_pic.c
@@ -271,12 +271,9 @@ static int pxa2xx_pic_post_load(void *opaque, int
version_id)
return 0;
}
-DeviceState *pxa2xx_pic_init(hwaddr base, ARMCPU *cpu)
+static void pxa2xx_pic_reset_hold(Object *obj)
{
- DeviceState *dev = qdev_new(TYPE_PXA2XX_PIC);
- PXA2xxPICState *s = PXA2XX_PIC(dev);
-
- s->cpu = cpu;
+ PXA2xxPICState *s = PXA2XX_PIC(obj);
s->int_pending[0] = 0;
s->int_pending[1] = 0;
@@ -284,6 +281,14 @@ DeviceState *pxa2xx_pic_init(hwaddr base, ARMCPU *cpu)
s->int_enabled[1] = 0;
s->is_fiq[0] = 0;
s->is_fiq[1] = 0;
+}
+
+DeviceState *pxa2xx_pic_init(hwaddr base, ARMCPU *cpu)
+{
+ DeviceState *dev = qdev_new(TYPE_PXA2XX_PIC);
+ PXA2xxPICState *s = PXA2XX_PIC(dev);
+
+ s->cpu = cpu;
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
@@ -319,9 +324,11 @@ static const VMStateDescription vmstate_pxa2xx_pic_regs = {
static void pxa2xx_pic_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
+ ResettableClass *rc = RESETTABLE_CLASS(klass);
dc->desc = "PXA2xx PIC";
dc->vmsd = &vmstate_pxa2xx_pic_regs;
+ rc->phases.hold = pxa2xx_pic_reset_hold;
}
static const TypeInfo pxa2xx_pic_info = {
--
2.41.0
- [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface,
Philippe Mathieu-Daudé <=
- [PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 8/9] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Richard Henderson, 2023/10/21
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Peter Maydell, 2023/10/27