[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link propert
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property |
Date: |
Fri, 20 Oct 2023 15:03:28 +0200 |
QOM objects shouldn't access each other internals fields
except using the QOM API.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/pxa2xx_pic.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/arm/pxa2xx_pic.c b/hw/arm/pxa2xx_pic.c
index 2eb869a605..7e180635c2 100644
--- a/hw/arm/pxa2xx_pic.c
+++ b/hw/arm/pxa2xx_pic.c
@@ -15,6 +15,7 @@
#include "cpu.h"
#include "hw/arm/pxa.h"
#include "hw/sysbus.h"
+#include "hw/qdev-properties.h"
#include "migration/vmstate.h"
#include "qom/object.h"
#include "target/arm/cpregs.h"
@@ -288,7 +289,8 @@ DeviceState *pxa2xx_pic_init(hwaddr base, ARMCPU *cpu)
DeviceState *dev = qdev_new(TYPE_PXA2XX_PIC);
PXA2xxPICState *s = PXA2XX_PIC(dev);
- s->cpu = cpu;
+ object_property_set_link(OBJECT(dev), "arm-cpu",
+ OBJECT(cpu), &error_abort);
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
@@ -321,11 +323,18 @@ static const VMStateDescription vmstate_pxa2xx_pic_regs =
{
},
};
+static Property pxa2xx_pic_properties[] = {
+ DEFINE_PROP_LINK("arm-cpu", PXA2xxPICState, cpu,
+ TYPE_ARM_CPU, ARMCPU *),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
static void pxa2xx_pic_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
ResettableClass *rc = RESETTABLE_CLASS(klass);
+ device_class_set_props(dc, pxa2xx_pic_properties);
dc->desc = "PXA2xx PIC";
dc->vmsd = &vmstate_pxa2xx_pic_regs;
rc->phases.hold = pxa2xx_pic_reset_hold;
--
2.41.0
- [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property,
Philippe Mathieu-Daudé <=
- [PATCH v3 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 8/9] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Richard Henderson, 2023/10/21
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Peter Maydell, 2023/10/27