Re: [PATCH v5 02/31] target/hppa: Remove object_class_is_abstract()

[Gavin Shan]

On 11/15/23 21:18, BALATON Zoltan wrote:
> On Wed, 15 Nov 2023, Gavin Shan wrote:
> > No need to check if @oc is abstract because it has been covered
> > by cpu_class_by_name().
> >
> > Signed-off-by: Gavin Shan <gshan@redhat.com>
> > ---
> > target/hppa/cpu.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
> > index 04de1689d7..fc4d2abad7 100644
> > --- a/target/hppa/cpu.c
> > +++ b/target/hppa/cpu.c
> > @@ -163,7 +163,6 @@ static ObjectClass *hppa_cpu_class_by_name(const char 
> > *cpu_model)
> >     ObjectClass *oc = object_class_by_name(typename);
> >
> >     if (oc &&
> > -        !object_class_is_abstract(oc) &&
> >         object_class_dynamic_cast(oc, TYPE_HPPA_CPU)) {
>
> Might as well remove the line break as the remaining expression fits in 80 
> chars.

Yes, but the whole chunk of code will be removed in PATCH[03]. So I think
we needn't the extra effort to adjust the format in PATCH[02]?

Thaks,
Gavin

> >         return oc;
> >     }