Re: [PATCH v5 03/31] cpu: Call object_class_dynamic_cast() once in cpu_class_by_name()

[Gavin Shan]

Hi Phil,

On 11/17/23 02:08, Philippe Mathieu-Daudé wrote:
> On 15/11/23 00:56, Gavin Shan wrote:
> > From: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> > For all targets, the CPU class returned from CPUClass::class_by_name()
> > and object_class_dynamic_cast(oc, CPU_RESOLVING_TYPE) need to be
> > compatible. Lets apply the check in cpu_class_by_name() for once,
> > instead of having the check in CPUClass::class_by_name() for individual
> > target.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Reviewed-by: Gavin Shan <gshan@redhat.com>
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> Gavin, this patch is missing your S-o-b tag. Do you mind responding to
> this email with it? Thanks!

Yes, please add my s-o-b if you need:

Signed-off-by: Gavin Shan <gshan@redhat.com>

Thanks,
Gavin

> > ---
> >   hw/core/cpu-common.c   | 8 +++++---
> >   target/alpha/cpu.c     | 3 ---
> >   target/arm/cpu.c       | 4 +---
> >   target/avr/cpu.c       | 8 +-------
> >   target/cris/cpu.c      | 4 +---
> >   target/hexagon/cpu.c   | 4 +---
> >   target/hppa/cpu.c      | 7 +------
> >   target/loongarch/cpu.c | 8 +-------
> >   target/m68k/cpu.c      | 4 +---
> >   target/openrisc/cpu.c  | 4 +---
> >   target/riscv/cpu.c     | 4 +---
> >   target/tricore/cpu.c   | 4 +---
> >   target/xtensa/cpu.c    | 4 +---
> >   13 files changed, 16 insertions(+), 50 deletions(-)