[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 09/25] block: Fix bdrv_find_backing_image()
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v4 09/25] block: Fix bdrv_find_backing_image() |
Date: |
Mon, 16 Jan 2017 16:08:33 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/16/2017 02:49 PM, Max Reitz wrote:
> bdrv_find_backing_image() should use bdrv_get_full_backing_filename() or
> bdrv_make_absolute_filename() instead of trying to do what those
> functions do by itself.
>
> path_combine_deprecated() can now be dropped, so let's do that.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 28 +++++++++++++---------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v4 03/25] block: Add BDS.backing_overridden, (continued)
- [Qemu-block] [PATCH v4 04/25] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2017/01/11
- [Qemu-block] [PATCH v4 05/25] block: Make path_combine() return the path, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 06/25] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 07/25] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 08/25] block: Add bdrv_make_absolute_filename(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 09/25] block: Fix bdrv_find_backing_image(), Max Reitz, 2017/01/16
- Re: [Qemu-block] [PATCH v4 09/25] block: Fix bdrv_find_backing_image(),
Eric Blake <=
- [Qemu-block] [PATCH v4 10/25] block: Add bdrv_dirname(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 11/25] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 12/25] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 13/25] block/nbd: Implement bdrv_dirname(), Max Reitz, 2017/01/16