[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 12/25] quorum: Make bdrv_dirname() return NUL
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v4 12/25] quorum: Make bdrv_dirname() return NULL |
|
Date: |
Mon, 16 Jan 2017 17:13:20 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/16/2017 02:49 PM, Max Reitz wrote:
> While the common implementation for bdrv_dirname() should return NULL
> for quorum BDSs already (because they do not have a file node and their
> exact_filename field should be empty), there is no reason not to make
> that explicit.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/quorum.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v4 07/25] block: bdrv_get_full_backing_filename's ret. val., (continued)
- [Qemu-block] [PATCH v4 08/25] block: Add bdrv_make_absolute_filename(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 09/25] block: Fix bdrv_find_backing_image(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 10/25] block: Add bdrv_dirname(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 11/25] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 12/25] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2017/01/16
- Re: [Qemu-block] [PATCH v4 12/25] quorum: Make bdrv_dirname() return NULL,
Eric Blake <=
- [Qemu-block] [PATCH v4 13/25] block/nbd: Implement bdrv_dirname(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 14/25] block/nfs: Implement bdrv_dirname(), Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 15/25] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 16/25] block: Add 'base-directory' BDS option, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 17/25] iotests: Add quorum case to test 110, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 19/25] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 18/25] block: Add sgfnt_runtime_opts to BlockDriver, Max Reitz, 2017/01/16
- [Qemu-block] [PATCH v4 20/25] block: Generically refresh runtime options, Max Reitz, 2017/01/16