Re: [Qemu-block] [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2()

From:	Eric Blake
Subject:	Re: [Qemu-block] [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn
Date:	Thu, 1 Mar 2018 16:56:17 -0600
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/01/2018 10:36 AM, Paolo Bonzini wrote:

From: Stefan Hajnoczi <address@hidden>

qcow2_create2() calls qemu_co_mutex_lock().  Only a coroutine_fn may
call another coroutine_fn.  In fact, qcow2_create2 is always called from
coroutine context.

Rename the function to add the "co" moniker and add coroutine_fn.

Reported-by: Marc-André Lureau <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


More of the funny double-Message-Id/S-o-b.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 3/8] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2018/03/01
  - Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Eric Blake, 2018/03/01
- [Qemu-block] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn, Paolo Bonzini, 2018/03/01
  - Re: [Qemu-block] [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn, Eric Blake <=
- [Qemu-block] [PATCH 4/8] qcow2: fix flushing after dirty bitmap metadata writes, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts(), Paolo Bonzini, 2018/03/01
  - Re: [Qemu-block] [Qemu-devel] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts(), Eric Blake, 2018/03/01
- [Qemu-block] [PATCH 5/8] qcow2: make qcow2_do_open a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 6/8] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 7/8] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 8/8] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2018/03/01
- Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context, Kevin Wolf, 2018/03/06
  - Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context, Paolo Bonzini, 2018/03/06
- Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context, Kevin Wolf, 2018/03/06

Prev by Date: [Qemu-block] [PULL 23/30] Include less of the generated modular QAPI headers
Next by Date: Re: [Qemu-block] [PATCH 2/7] qcow2: Check L1 table offset in qcow2_snapshot_load_tmp()
Previous by thread: [Qemu-block] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn
Next by thread: [Qemu-block] [PATCH 4/8] qcow2: fix flushing after dirty bitmap metadata writes
Index(es):
- Date
- Thread