[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from cor
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context |
Date: |
Tue, 6 Mar 2018 14:59:24 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 01.03.2018 um 17:36 hat Paolo Bonzini geschrieben:
> Check and invalidate_cache share some parts of the implementation
> with the regular I/O path. This is sometimes complicated because the
> I/O path wants to use a CoMutex but that is not possible outside coroutine
> context. By moving things to coroutine context, we can remove special
> cases. In fact, invalidate_cache is already called from coroutine context
> because incoming migration is placed in a coroutine.
>
> I'm including two patches from Stefan to rename the bdrv_create callback
> to bdrv_co_create, because it is already called from coroutine context.
> The name is now bdrv_co_create_opts, with bdrv_co_create reserved for
> the QAPI-based version that Kevin is working on.
>
> qcow2 still has cache flushing in non-coroutine context, coming from
> qcow2_reopen_prepare->qcow2_update_options_prepare,
> qcow2_close->qcow2_inactivate and several dirty bitmap functions.
Hmm... Which commit is this based on? I can't seem to find one where it
applies cleanly.
Kevin
- Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, (continued)
- [Qemu-block] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 4/8] qcow2: fix flushing after dirty bitmap metadata writes, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts(), Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 5/8] qcow2: make qcow2_do_open a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 6/8] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 7/8] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-block] [PATCH 8/8] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2018/03/01
- Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context,
Kevin Wolf <=
- Re: [Qemu-block] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context, Kevin Wolf, 2018/03/06