[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/4] nbd/server: refactor nbd_negotiate_meta_que
|
From: |
Wouter Verhelst |
|
Subject: |
Re: [Qemu-block] [PATCH 1/4] nbd/server: refactor nbd_negotiate_meta_query for several namespaces |
|
Date: |
Wed, 21 Mar 2018 18:20:39 +0100 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Wed, Mar 21, 2018 at 09:56:36AM -0500, Eric Blake wrote:
> no further qemu patches are submitted. Is it worth me proposing a doc
> change to demonstrate what the difference would look like, along with
> corresponding qemu changes to match, to decide if including it in 2.12 is
> worth it?
If you're willing to spend the effort, I won't stop you :-) but I think the
pain of parsing a string once (during negotiation) is not that bad, and
I'm not too bothered about it.
Put otherwise, I'm not convinced that the downside (which I agree
exists) outweighs the downside of having to introduce yet another
command, or add some ugliness for backwards compat reasons.
But hey, go ahead, prove me wrong ;-)
--
Could you people please use IRC like normal people?!?
-- Amaya Rodrigo Sastre, trying to quiet down the buzz in the DebConf 2008
Hacklab
[Qemu-block] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper, Vladimir Sementsov-Ogievskiy, 2018/03/21
[Qemu-block] [PATCH 1/4] nbd/server: refactor nbd_negotiate_meta_query for several namespaces, Vladimir Sementsov-Ogievskiy, 2018/03/21
[Qemu-block] [PATCH 3/4] nbd/server: implement dirty bitmap export, Vladimir Sementsov-Ogievskiy, 2018/03/21